Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Fit): add component, playground, demo #389

Merged
merged 6 commits into from
May 2, 2024
Merged

feat(Fit): add component, playground, demo #389

merged 6 commits into from
May 2, 2024

Conversation

andretchen0
Copy link
Contributor

closes #379

This component is similar in spirit to Drei's <Resize />. But it also allows for scaling/positioning children of <Fit /> to:

  • fit in a Box3
  • fit in an Object3D's computed AABB
  • fit into a 1 x 1 x 1 Box3 at world origin if no :into prop is provided

Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I was playing with it, works just fine.

I just drop little changes, nothing too big

Also, please your demo is fantastic, but some comments would improve drastically the component, I was struggling understanding what's going on hahaha

src/core/staging/Fit.vue Outdated Show resolved Hide resolved
playground/src/pages/staging/FitDemo.vue Show resolved Hide resolved
src/core/staging/Fit.vue Outdated Show resolved Hide resolved
src/core/staging/Fit.vue Outdated Show resolved Hide resolved
@andretchen0
Copy link
Contributor Author

Nice one, I was playing with it, works just fine.

I just drop little changes, nothing too big

Also, please your demo is fantastic, but some comments would improve drastically the component, I was struggling understanding what's going on hahaha

Hey! Thanks for the feedback. Always nice to get fresh eyes on something.

@andretchen0
Copy link
Contributor Author

andretchen0 commented Apr 30, 2024

Also, please your demo is fantastic, but some comments would improve drastically the component, I was struggling understanding what's going on hahaha

@JaimeTorrealba No problem. Would you like the demo to be commented, or the component, or both? Any parts in particular?

I added some comments in the component and the playground demo. Let me know if there's another place you feel would be helpful.

@JaimeTorrealba
Copy link
Member

Also, please your demo is fantastic, but some comments would improve drastically the component, I was struggling understanding what's going on hahaha

@JaimeTorrealba No problem. Would you like the demo to be commented, or the component, or both? Any parts in particular?

I added some comments in the component and the playground demo. Let me know if there's another place you feel would be helpful.

This is more for future features :)

Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like you have to resolve some conflict, but for me is ready :)

@JaimeTorrealba
Copy link
Member

@andretchen0 Hi man sorry for write here again, we're going to release the 3.9 of cientos because we have several features. I would like to include this, are you ok if I solve the conflicts? or you prefer solve them ??

@andretchen0
Copy link
Contributor Author

andretchen0 commented May 1, 2024

Hey @JaimeTorrealba , I fixed the conflict by merging in the latest main.

But latest main can't pass the linter – I've opened a PR on Cientos that lints main.

Since main can't pass the CI linter, this PR can't, for the moment. But the files touched by this PR are linted.

Edit: Upstream linter errors were fixed and merged here. Merged this PR.

@andretchen0 andretchen0 merged commit 3915215 into main May 2, 2024
2 checks passed
@andretchen0 andretchen0 deleted the feat/fit branch May 2, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility component: Resize
2 participants