-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Fit): add component, playground, demo #389
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, I was playing with it, works just fine.
I just drop little changes, nothing too big
Also, please your demo is fantastic, but some comments would improve drastically the component, I was struggling understanding what's going on hahaha
Hey! Thanks for the feedback. Always nice to get fresh eyes on something. |
@JaimeTorrealba No problem. Would you like the demo to be commented, or the component, or both? Any parts in particular? I added some comments in the component and the playground demo. Let me know if there's another place you feel would be helpful. |
This is more for future features :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like you have to resolve some conflict, but for me is ready :)
@andretchen0 Hi man sorry for write here again, we're going to release the 3.9 of cientos because we have several features. I would like to include this, are you ok if I solve the conflicts? or you prefer solve them ?? |
Hey @JaimeTorrealba , I fixed the conflict by merging in the latest But latest Since Edit: Upstream linter errors were fixed and merged here. Merged this PR. |
closes #379
This component is similar in spirit to Drei's
<Resize />
. But it also allows for scaling/positioning children of<Fit />
to:Box3
Object3D
's computedAABB
Box3
at world origin if no:into
prop is provided