Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: V4 #420

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from
Draft

feat: V4 #420

wants to merge 99 commits into from

Conversation

JaimeTorrealba
Copy link
Member

No description provided.

andretchen0 and others added 30 commits January 11, 2024 22:31
@andretchen0
feat(AnimatedSprite): add AnimatedSprite, playground, docs
d6ea81b
@andretchen0
chore(AnimatedSprite): fix linter errors
e7ff5a2
@andretchen0
chore(AnimatedSprite): update docs
c74c332
@andretchen0
feat(AnimatedSprite): allow [numCols, numRows] as atlas prop
3309d9c
@andretchen0
docs(AnimatedSprite): reorder sections, improve clarity
49380ee
@andretchen0
docs(AnimatedSprite): format type names
c2bfd63
@andretchen0
docs(AnimatedSprite): update no-atlas example to use [cols, rows]
d4a7528
@andretchen0
chore(AnimatedSprite): run linter, remove console.log
823c8d7
@andretchen0
refactor(AnimatedSprite): create new animation frames if props.revers…
3db5140 
…ed is toggled
@andretchen0
docs(AtlasAnimationDefinitionParser): change 'delay' to 'duration'
970c91b
@andretchen0
refactor(AtlasAnimationDefinitionParser): make parse function private…
fbda429 
… to module
@andretchen0
refactor(AtlasAnimationDefinitionParser): use destructuring
612c9ba
@andretchen0
refactor(AtlasAnimationDefinitionParser): use destructuring
4adc67a
@andretchen0
refactor(AtlasAnimationDefinitionParser): rename returned value 'result'
8c586ad
@andretchen0
chore: run linter
db74f59
@andretchen0
refactor(AtlasAnimationDefinitionParser): rename private error loggin…
0cb9788 
…g functions
@andretchen0
refactor(Atlas): rename private functions
d45ae6d
@andretchen0
fix(Atlas): add missing argument to function call
e6b147e
@andretchen0
refactor(AnimatedSprite): merge FrameData types as single type
9481afe
@andretchen0
refactor(AnimatedSprite): change callbacks to emits
f2edc12
@andretchen0
chore(AnimatedSprite): run linter
1adcc1a
@andretchen0
chore(AnimatedSprite): format Atlas error message
6daa414
@andretchen0
fix(AnimatedSprite): return nullFrame animation if requested animatio…
453819e 
…n not found
@andretchen0
refactor(AnimatedSprite): simplify component onLoop
c8f96d7
@andretchen0
chore(AnimatedSprite): run lint --fix
2b71c80
@andretchen0
refactor(AnimatedSprite): add Atlasish type
6264d13
@andretchen0
refactor(AnimatedSprite): remove onLoad prop
d560368
@JaimeTorrealba
feat(app)!: 227 Change the keyboardcontrols implementation
fed0f86
@andretchen0
docs(AnimatedSprite): update docs and demos
6a61810
@andretchen0
docs(AnimatedSprite): update playground demo
1467129
@stackblitz StackBlitz
Copy link

stackblitz bot commented May 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@JaimeTorrealba JaimeTorrealba marked this pull request as draft May 15, 2024 14:47
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

❌ Deploy Preview for cientos-tresjs failed.

Name Link
🔨 Latest commit 981de57
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/6675585f2952aa0008aff0e2

JaimeTorrealba and others added 20 commits May 15, 2024 16:02
@JaimeTorrealba
chore: fix demos
237763c
@JaimeTorrealba
chore: fix lint
8eaccf6
@JaimeTorrealba
feat(app): 421 Adapt components to use useLoop instead of useRenderLoop
24e9812
@alvarosabu
Revert "feat(app): 421 Adapt components to use useLoop instead of use…
ec12a13 
…RenderLoop"

This reverts commit 24e9812.
@JaimeTorrealba
feat(app): 421 Update components to use useLoop instead of useRenderLoop
ad3b290
@JaimeTorrealba
chore: update statsGl y stats
b2e053d
@JaimeTorrealba
fix lint
3c95d43
@JaimeTorrealba
chore: update useEnviroment
3d61e4f
@JaimeTorrealba
chore: update fbo
75d4e26
@JaimeTorrealba
chore: lint
0ea4a22
@JaimeTorrealba
Merge branch 'main' into fix/lint-problems-sky-hologram
03a4409
@JaimeTorrealba
feat: re-remove tweakpane (#425)
72284ce 
* feat(app)!: 313 re-uninstall tweakpane

* chore: fix lint
@JaimeTorrealba
Merge remote-tracking branch 'origin/v4' into fix/lint-problems-sky-h…
f35c398 
…ologram
@JaimeTorrealba
Merge pull request #426 from Tresjs/fix/lint-problems-sky-hologram
6794dfe 
fix: lint problems sky hologram
@JaimeTorrealba
docs: update enviroment and useEnviroment docs
e1fa06f
@JaimeTorrealba
fix: remove hardcoded speed number, that setting at 0 doesn't stop th…
e67f3a2 
…e effect
@JaimeTorrealba
Merge remote-tracking branch 'origin/v4' into feature/421-adapt-abstr…
c5802f4 
…actions-to-useloop-instead-of-userenderloop
@JaimeTorrealba
update lock
c93e013
@JaimeTorrealba
Merge pull request #422 from Tresjs/feature/421-adapt-abstractions-to…
f8c0619 
…-useloop-instead-of-userenderloop

feat(app): 421 Update components to use useLoop instead of useRenderLoop
@JaimeTorrealba
Merge pull request #427 from Tresjs/docs/update-enviroment-docs
43b0648 
docs: update enviroment and useEnviroment docs
@alvarosabu
Copy link
Member

Screenshot 2024-05-28 at 14 30 52

@JaimeTorrealba try checking that all the actions passed before merging, the latest two merged broke the deployment

@JaimeTorrealba
Copy link
Member Author

JaimeTorrealba commented May 28, 2024 •
edited
Loading

@alvarosabu the checks of linters are good the others like in the image, I can't see them

image

I believe probably they're from netlify

@alvarosabu
Copy link
Member

@JaimeTorrealba The Netlify deployment is just the docs, try building the docs locally to check why is not working.

@andretchen0
chore: add Cylinder to v4 (#439)
befe2fc 
* chore: add Cylinder to v4

* chore: fix playground link
@andretchen0
fix(Lensflare demo): add camera #435 (#441)
981de57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu Awaiting requested review from alvarosabu

@andretchen0 andretchen0 Awaiting requested review from andretchen0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JaimeTorrealba @alvarosabu @andretchen0