Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vue attrs hyphenation issues #424

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: vue attrs hyphenation issues #424

merged 2 commits into from
May 17, 2024

Conversation

alvarosabu
Copy link
Member

No description provided.

@alvarosabu alvarosabu added the p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority) label May 16, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented May 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 82fe77b
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/664689bb65311e0008fa315f
😎 Deploy Preview https://deploy-preview-424--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu mentioned this pull request May 16, 2024
Merged
18 tasks
andretchen0
andretchen0 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Leches values weren't working in SkyDemo. I updated them:

.value.value -> .value

@JaimeTorrealba JaimeTorrealba merged commit 77b2220 into main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andretchen0 andretchen0 andretchen0 approved these changes

@JaimeTorrealba JaimeTorrealba Awaiting requested review from JaimeTorrealba

Assignees
No one assigned
Labels
p5-urgent-bug Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvarosabu @andretchen0 @JaimeTorrealba