Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #75

Open
alvarosabu opened this issue Nov 17, 2023 · 8 comments · May be fixed by #95
Open

Dark mode #75

alvarosabu opened this issue Nov 17, 2023 · 8 comments · May be fixed by #95
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alvarosabu
Copy link
Member

Inevitable 😂

@alvarosabu alvarosabu added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 17, 2023
@Readpato
Copy link
Collaborator

Readpato commented Nov 27, 2023

Hey @alvarosabu, if it's possibile, I would like to help with this issue =]

I assume that when we are talking about dark mode we are talking directly about the Leches GUI, right? Because I have noticed that on the Leches website the dark mode doesn't work correctly

image
Screenshot 2023-11-27 at 19 12 03

I could open a different issue for this specific case if needed so we don't mix things up, let me know. Glad to help!

@alvarosabu
Copy link
Member Author

Hi @Readpato thanks for steping in, yes I mean the actual GUI interface, I will fix the docs dark mode in another PR

@Readpato
Copy link
Collaborator

Readpato commented Nov 27, 2023

Perfect then, I'll proceed with adding dark mode to the GUI!

@Readpato
Copy link
Collaborator

Readpato commented Nov 27, 2023

Hey @alvarosabu would you know why this error appears? Can't seem to fix it

GET http://localhost:5173/src/main.ts net::ERR_ABORTED 500 (Internal Server Error)

image

I have tried:

  • Reinstalling deps
  • Changing import to @tresjs/leches/styles.css
  • Changing node version from 20.10.0 to 19.3.0
    But sadly no luck.

I have also seen the answer you gave to Marcin Dekier in discord about the same issue and solving it by importing the styles globally on his Nuxt project maybe it's something related to it?

@alvarosabu
Copy link
Member Author

Try building the lib, if you change the source on the viteconf to src instead of dist the alias wouldn't work and you would need to import the styles from complete the .css path

@Readpato
Copy link
Collaborator

Readpato commented Nov 28, 2023

Perfect, it worked after running pnpm run build, thanks!

@alvarosabu
Copy link
Member Author

Yo buddy @Readpato I fixed some css issues and updated the deps on the latest release, make sure you merge latest main into your branch

@Readpato
Copy link
Collaborator

Purrfect, will do it! Thanks <3

@Readpato Readpato mentioned this issue Dec 8, 2023
11 tasks
@Readpato Readpato linked a pull request Dec 17, 2023 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants