feat(post-processing): refactor of existing effects #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 29, 2023 09:52
Tinoooo
requested review from
alvarosabu and
JaimeTorrealba
and removed request for
alvarosabu
alvarosabu
reviewed
Oct 7, 2023
alvarosabu
approved these changes
Oct 9, 2023
| @@ -44,11 +44,30 @@ export const makePropWatcher = <T, E>( | |||
| * @param {Ref<E>} target - A Ref representing the target object to be updated. | |||
| * @param {() => E & { dispose?(): void }} newPlainObjectFunction - A function that creates a new plain object to retrieve the defaults from with an optional "dispose" method for cleanup. | |||
| */ | |||
| export const makePropWatchers = <T, E>( | |||
| propGettersAndPropertyPaths: (string | (() => T))[][], | |||
| export const makePropWatchers = <E>( | |||
There was a problem hiding this comment.
I find this really useful, @andretchen0 @JaimeTorrealba maybe we should consider it cross-packages.
Do we have enough utils around to make a package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.