fix(usetrescontextprovider): fixed rendering issues caused when resize is triggered #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @Steve245270533 thank you very much for taking the time to open a ticket and create a PR with the fix, looks pretty solid, the debounce makes sense and it will also improve the performance I will test it and give you feedback 🙏🏻 |
alvarosabu
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved this issue (#511)
By minimizing the scene reproduction, I found that the real cause of jitter during rendering is the use of the two APIs
useElementSize/useWindowSize.They both use the ResizeObserver API, which is always a few milliseconds slower than the triggering of the onResize event.
I also compared the behavior of R3F when resizing and found that there is an anti shake operation.
Therefore, we only need to perform an anti-shake operation on the width and height values to solve the problem.