feat(core): allow using window as pointer events source #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
What do you think about expanding the tres/src/components/TresCanvas.vue Line 65 in 43cd1a4 My take: I'm completely on board with allowing additional ways for the system to get events. But, rather than passing a boolean flag that has to be implemented by the system for this particular case, I'd prefer to invert the dependencies. E.g., define a default Maybe that's something that can wait though. |
alvarosabu
added
p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
useWindowPointerprop to TresCanvas that states whether or not to use the window as the source of pointer events.Closes #581
Added the prop to docs page, let me know if I'm missing anything 😄