Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEEDS THOUGHT] added initial translation setup #295

Closed
wants to merge 6 commits into from

Conversation

introkun
Copy link
Contributor

@introkun introkun commented Apr 5, 2024

Checklist

  • Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • ✨ Feature
  • ♻️ Code Refactor

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

@TreyWW TreyWW marked this pull request as draft April 6, 2024 16:33
@introkun
Copy link
Contributor Author

introkun commented Apr 6, 2024

marked this pull request as draft
Any comments @TreyWW ?

@TreyWW TreyWW changed the title added initial translation setup [NEEDS THOUGHT] added initial translation setup Apr 25, 2024
@github-actions github-actions bot added Stale and removed Stale labels May 9, 2024
@github-actions github-actions bot added the Stale label May 24, 2024
@github-actions github-actions bot closed this May 29, 2024
@TreyWW
Copy link
Owner

TreyWW commented May 29, 2024

Hmm I've been looking over this a few times over the last week and I am considering it. It's just I feel like it's going to make all of the messages much harder. Like would formatting (e.g ) work in the messages?

And with the Django tags, trans, anything dynamic is just a pain to put in tags (I believe).

It could be a good option, I'll open up the PR again and maybe give it a go, see how it is.

Sorry about the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants