Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy type errors fix #348

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Mypy type errors fix #348

merged 9 commits into from
Apr 25, 2024

Conversation

Domejko
Copy link
Contributor

@Domejko Domejko commented Apr 23, 2024 •
edited
Loading

Description

Regarding #319

  • error count reduced to 269

Edit:

  • error count reduced to 99

Checklist

  • Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • 🐛 Bug Fix
  • ♻️ Code Refactor

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

TreyWW
TreyWW requested changes Apr 23, 2024
View reviewed changes
backend/api/invoices/delete.py Outdated Show resolved Hide resolved
settings/local_settings.py Show resolved Hide resolved
settings/prod_settings.py Show resolved Hide resolved
@Domejko Domejko requested a review from TreyWW April 23, 2024 16:27
TreyWW
TreyWW approved these changes Apr 25, 2024
View reviewed changes
Copy link
Owner

@TreyWW TreyWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR, thanks!

@TreyWW TreyWW merged commit 6f34bbb into TreyWW:main Apr 25, 2024
11 checks passed
@Domejko Domejko deleted the mypy-errors-fix branch April 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TreyWW TreyWW TreyWW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Domejko @TreyWW