Treat compiler flags verbatim for installation #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works correctly for quotes around individual compiler arguments.
This matches what was done in the previous commit for the file TribitsProjectConfigTemplate.cmake.in pulled over from the Trilinos PR trilinos/Trilinos#9189. This should allow quoted compiler args to remain as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to the TriBITS patch in trilinos/Trilinos#9189.
The commit f68c8ed in this PR branch exactly corresponds to the updated commit trilinos/Trilinos@bba1833 in PR trilinos/Trilinos#9189 so the merge of updated snapshotted TriBITS should go smoothly (but I will test that).
How was this tested?
The existing local TriBITTS test suite passed but that is not saying a lot. The TriBITS tests of these exported files is very superficial. But it did catch the defect in the commit trilinos/Trilinos@66b4f18 fixed by the commit trilinos/Trilinos@30d6e2e (before I squashed these two together in the new commit trilinos/Trilinos@bba1833).
These tests will need to be beefed up substantially before I make major changes as part of #299 and #375.