Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriBITS CI testing with GitHub Actions (#363) #389

Commits on Jul 15, 2021

  1. Configuration menu
    Copy the full SHA
    62cc3ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42c175a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad56911 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Configuration menu
    Copy the full SHA
    2c1af51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15959a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dabbcf8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3fabb91 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3d15fef View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    02da36a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6af8a6a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    135b19a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    06ba32b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6a51fe7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    adf2d2a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7acbfbd View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    127601f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9a62a04 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3e0b5bb View commit details
    Browse the repository at this point in the history
  16. TriBITSPub#377: - fix memory problem

    - fix if
    marcinwrobel1986 committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    fd4040f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2a6bd9c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    fdaf159 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9429c53 View commit details
    Browse the repository at this point in the history
  20. Disable submits to CDash

    So we can debug some without spamming CDash
    bartlettroscoe committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    895d469 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Configuration menu
    Copy the full SHA
    63dc18a View commit details
    Browse the repository at this point in the history
  2. Add GitHub Actions-specific driver (TriBITSPub#363)

    But any non-trivial logic in a script, we can develop and test it locally.
    This is a win-win-win over putting all of this logic in the GitHub Action YAML
    file.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    2aa9ffb View commit details
    Browse the repository at this point in the history
  3. Switch over to use run_github_actions_ctest_driver.sh (TriBITSPub#363)

    This should have the proper site name, build name, use the correct generator,
    and enable or disable Fortran correctly.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5656f5a View commit details
    Browse the repository at this point in the history
  4. Change max-parallel from 1 to 4 (TriBITSPub#363)

    Why not let the jobs run all at the same time?
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a33fc8a View commit details
    Browse the repository at this point in the history
  5. No more hello_world.yml (TriBITSPub#363)

    We have a real GitHub Actions now.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    8619153 View commit details
    Browse the repository at this point in the history
  6. Fix path to run run_github_actions_ctest_driver.sh (TriBITSPub#363)

    The script now creates and cds into 'tribits-build' subdir.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    fd7e45a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c76f708 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4f57dc6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8c5fe4e View commit details
    Browse the repository at this point in the history
  10. Allow --fortran-compiler-and-ver with no val, improve cmndline checki…

    …ng, improve output (TriBITSPub#363)
    
    Hopefully this will run correctly now for all of the build from the GitHub
    Actions YAML file.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    fa559e3 View commit details
    Browse the repository at this point in the history
  11. Don't test build of docs for now (TriBITSPub#363)

    We will need to install docutils if we want to test the generation of
    documentation.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    091a21d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    70de392 View commit details
    Browse the repository at this point in the history
  13. Make all builds use makefiles for now (TriBITSPub#363)

    I suspect that some of the tests are not robust enough to work with Ninja as
    the outer generator.  There are some tests that will use Ninja for the inner
    configure to make sure that it works.
    
    Making the entire TriBITS test suite pass using Ninja as the generator in
    place of Makefiles would be a lot of work.  Or, we could conditionally enable
    many of the tests that depend Unix Makefile logic.
    bartlettroscoe committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5ff5d9e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Set TriBITS_SHOW_TEST_START_END_DATE_TIME=ON (TriBITSPub#363)

    Nice to set just for completeness.  Not really related to TriBITSPub#363 but I did this
    while workoing on that.
    
    I also moved -DDART_TESTING_TIMEOUT=60 up in the argument list because
    -DCTEST_PARALLEL_LEVEL=16 these kind of go together.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f72490d View commit details
    Browse the repository at this point in the history
  2. Adjust for MixedLang disable with no Fortran (TriBITSPub#363)

    This is one of the test cases being enabled for the GitHub Actions builds for
    TriBITS in TriBITSPub#363.  Just reproducing locally and fixing.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d2ddbaa View commit details
    Browse the repository at this point in the history
  3. Disable a bunch of tests that fail if there is no Fortran (TriBITSPub…

    …#363)
    
    All of these tests fail to configure because we don't pass down the
    ENABLE_Fortran configure option to the inner CMake configure and if a working
    Fortran compiler does not even exist on the system, then these tests fail in
    the configure of the inner project.  While I could pass down this info
    somehow, a lot of these tests would fail anyway without some adjustment.
    
    We don't need every test to run if we don't have a Fortran compiler.  We just
    don't want the TriBITS test suite to have a bunch of failing tests if a user
    clones the repo and tries to build and run the TriBITS test suite on a machine
    with no Fortran compiler (like a Mac or a Windows machine).
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1f397e0 View commit details
    Browse the repository at this point in the history
  4. Make WORLD_READABLE=TRUE set same perms as GROUP_WRITABLE (TriBITSPub…

    …#314, TriBITSPub#363)
    
    With CMake 3.21, with umask=g-rwx,o-rwx you need explicitly set g+rX for the
    group permissions to be r-X when setting
    <Project>_MAKE_INSTALL_WORLD_READABLE=ON which was doing just:
    
      chmod -R o+rX <dir>
    
    Now, when you ony set <Project>_MAKE_INSTALL_WORLD_READABLE=ON, you get:
    
      chmod -R g+rX,o+rX <dir>
    
    For some reason, with older verisons of CMake, it was setting the default
    group permission as 'r-x' when it should not have been.  I ran exactly the
    same build on the same machine (crf450) with the same env except I used CMake
    3.21.0 vs. 3.17.1 and I had to make this change to get the same permissions on
    the base install directory.  Strange.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d01b667 View commit details
    Browse the repository at this point in the history
  5. Adjust for different CMake 3.21 error output (TriBITSPub#363)

    For CMake 3.21 it prints a "could not find requested file" instead of "could
    not find load file".  The latter was obviously a typo so it is good they fixed
    it but I had this checked for in a test.  Now the test passes in both cases.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    aae3bed View commit details
    Browse the repository at this point in the history
  6. Adjust for different number of install errors reported by CMake 3.21 (T…

    …riBITSPub#363)
    
    Seems CMake 3.21 reports two install failures instead of just one as older
    versions of CMake reported.  I guess it depends how you count.  Either way,
    the number is greater than 0 so that is what matters really.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    65ee4e6 View commit details
    Browse the repository at this point in the history
  7. Adjust for move of rules.ninja in CMake 3.18 (TriBITSPub#363)

    I searched the git logs and it looks like this change was pulled in the CMake
    3.18.0 release.  But I only tested this with CMake 3.17.1 and 3.21.0.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    36af217 View commit details
    Browse the repository at this point in the history
  8. Update min version of CMake from 2.6 to 2.17 of old Fortran name mana…

    …ging code (TriBITSPub#363)
    
    With CMake 3.21, this was generating a deprecated warning.  With the rest of
    TriBITS requiring CMake 3.17 it seems bad to have code that has min version
    going back to 2.6.  However, this might change the behaivor of this code so
    that is a warning.  (Fingers crossed.)
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    3024a80 View commit details
    Browse the repository at this point in the history
  9. Merge remote-tracking branch 'rab-github/363-fix-ci-tests' into 377-g…

    …ithub-actions-ci (TriBITSPub#363)
    
    Merge in the fixes of the tests that should fix all of the nofortran failures
    and three of the cmake-3.21 failures.  But we expect there to still be 10
    failing cmake-3.21 failures due to changes in CMake 3.21 behavior vs. CMake
    3.17 that appears to be regressions.
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    87aa1d2 View commit details
    Browse the repository at this point in the history