Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and deprecate set_and_inc_dirs() to tribits_set_and_inc_dirs() (#429) #553

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Rename and deprecate set_and_inc_dirs() to tribits_set_and_inc_dirs() (#429) #553

merged 4 commits into from
Dec 20, 2022

Conversation

bartlettroscoe
Copy link
Member

Description

See the individual commit log messages for details.

Instructions for Reviewers

Please review the Git commits and Git commit log messages individually.

@bartlettroscoe
Move to TribitsSetAndIncDirs.cmake (TriBITSPub#429)
1eb314c 
Moved this from tribits/core/utils/ to tribits/core/package_arch/ so that it
can be refactored to use tribits_include_directories().
@bartlettroscoe
Change to call tribits_include_directories() (TriBITSPub#429)
a1c5651 
This removes the deprecation warning.
@bartlettroscoe
Rename and deprecate set_and_inc_dirs() to tribits_set_and_inc_dirs() (…
49a42bf 
…TriBITSPub#429)

Now that this macro has been moved into tribits/core/package_arch/ and calls
another macro in tribits/core/package_arch/, it should have the 'tribits_'
prefix.  (Actually, all TriBITS macros should have the `tribits_` prefix, even
those under tribits/core/utils/.)
@bartlettroscoe
Add replace_set_and_inc_dirs_r.sh and CHANGLOG entry (TriBITSPub#429)
b0749b0
@bartlettroscoe bartlettroscoe added this to In Progress in TriBITS Refactor via automation Dec 20, 2022
@bartlettroscoe bartlettroscoe moved this from In Progress to In Review in TriBITS Refactor Dec 20, 2022
rabartlett1972
rabartlett1972 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@rabartlett1972 rabartlett1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will allow the merge and set up for a post-merge review

@bartlettroscoe bartlettroscoe merged commit 5d37582 into TriBITSPub:master Dec 20, 2022
TriBITS Refactor automation moved this from In Review to Done Dec 20, 2022
@bartlettroscoe bartlettroscoe moved this from Done to In Review in TriBITS Refactor Dec 20, 2022
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Ifpack2: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
a3278eb 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
MiniTensor: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (
6cf1cf0 
TriBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
ML: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (TriBI…
9a592a6 
…TSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
MueLu: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tr…
94e3a74 
…iBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Percept: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
591aa95 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Pike: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tri…
01b8b0d 
…BITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
ROL: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (TriB…
19adf64 
…ITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
RTOp: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tri…
9e250e5 
…BITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Rythmos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
bc8b3c0 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
SEACAS: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
5c54600 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Stratimikos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs…
16628c0 
…() (TriBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Tempus: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
29da3af 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Teuchos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
610cded 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Thyra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tr…
bf0bb05 
…iBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Tpetra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
508d295 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Xpetra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
e0f3ddd 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Zoltan2: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
ac97b61 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Ifpack2: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
99dbebc 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
MiniTensor: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (
495eff2 
TriBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
ML: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (TriBI…
cdf0a03 
…TSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
MueLu: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tr…
e4c1a46 
…iBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Percept: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
d0d5126 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Pike: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tri…
cdd89bb 
…BITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
ROL: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (TriB…
5b48da2 
…ITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
RTOp: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tri…
71b920f 
…BITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Rythmos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
d6e6c5d 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
SEACAS: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
434800a 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Stratimikos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs…
b859bfe 
…() (TriBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Tempus: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
6130ea6 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Teuchos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
2c9c907 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Thyra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tr…
a7b089c 
…iBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Tpetra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
a239283 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Xpetra: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
e0ea232 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Dec 20, 2022
@bartlettroscoe
Zoltan2: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
eca14d3 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
@bartlettroscoe bartlettroscoe mentioned this pull request Dec 20, 2022
Merged
9 tasks
bartlettroscoe added a commit to bartlettroscoe/seacas that referenced this pull request Dec 21, 2022
@bartlettroscoe
SEACAS: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
6ece46f 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.

This matches a similar commit from PR trilinos/Trilinos#11380

I was not able to use git format-patch and git am to apply the patch from the
Trilinos branch due to no current clean snapshot so I had to run the tool
TriBITS/refactoring/replace_set_and_inc_dirs_r.sh from scratch.
KyleFromKitware
KyleFromKitware reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@KyleFromKitware KyleFromKitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleFromKitware KyleFromKitware moved this from In Review to Done in TriBITS Refactor Jan 16, 2023
cabejackson pushed a commit to trilinos/Rythmos that referenced this pull request Aug 16, 2023
@bartlettroscoe
Rythmos: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (T…
0e6e857 
…riBITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
cabejackson pushed a commit to trilinos/Pike that referenced this pull request Aug 16, 2023
@bartlettroscoe
Pike: Replace set_and_inc_dirs() with tribits_set_and_inc_dirs() (Tri…
8d5b1dc 
…BITSPub/TriBITS#429)

A refactoring in TriBITS related to tribits_include_directories() (see
TriBITSPub/TriBITS#553) required renaming set_and_inc_dirs() to
tribits_set_and_inc_dirs() and deprecating the former.  The deprecated TriBITS
macro set_and_inc_dirs() now issues a CMake Deprecation warning.  This change
wsa made with the TriBITS script:

  TriBITS/refactoring/replace_set_and_inc_dirs_r.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromKitware KyleFromKitware KyleFromKitware left review comments

@rabartlett1972 rabartlett1972 rabartlett1972 approved these changes

Assignees

@KyleFromKitware KyleFromKitware

Labels
component: core type: enhancement
Projects
TriBITS Refactor
Status: Done
TriBITS Refactor
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlettroscoe @KyleFromKitware @rabartlett1972