Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RUN_SERIAL to tribits_add_executable_and_test() (#554) #555

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

bartlettroscoe
Copy link
Member

Addresses #554.

It was an oversight that this was not added to tribits_add_executable_and_test() when it was added to tribits_add_test().

I tested this against Trilinos and the warning reported in trilinos/Trilinos#11411 went away.

It was an oversight that this was not added to
tribits_add_executable_and_test() when it was added to tribits_add_test().
Copy link
Collaborator

@rabartlett1972 rabartlett1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will allow to merge. This does not need a post-merge review because the changes are trivial.

@bartlettroscoe bartlettroscoe merged commit 3879de0 into TriBITSPub:master Dec 20, 2022
TriBITS Refactor automation moved this from In Progress to Done Dec 20, 2022
@bartlettroscoe
Copy link
Member Author

bartlettroscoe commented Dec 20, 2022

Also, I inspected the generated Trilinos file packages/stokhos/test/UnitTest/CTestTestfile.cmake and saw:

set_tests_properties(Stokhos_TpetraMatVec_MPI_4 PROPERTIES  ... RUN_SERIAL "ON" ...)

which is created from:

https://github.com/trilinos/Trilinos/blob/281650bb58e683daff5c41c90e22bbe3c407afc0/packages/stokhos/test/UnitTest/CMakeLists.txt#L865-L874

which was:

IF (Stokhos_ENABLE_Tpetra)
  TRIBITS_ADD_EXECUTABLE_AND_TEST(
    TpetraMatVec
    SOURCES tpetra_mat_vec.cpp
    COMM serial mpi
    STANDARD_PASS_OUTPUT
    #NUM_MPI_PROCS 4
    RUN_SERIAL
    )
ENDIF()

This validates that the RUN_SERIAL option was passed to the tribits_add_test() function correctly and that it was interpreted correctly by that function to set the RUN_SERIAL ctest property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants