Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types in Release #254

Closed
rgb000 opened this issue Feb 27, 2024 · 11 comments
Closed

Missing types in Release #254

rgb000 opened this issue Feb 27, 2024 · 11 comments

Comments

@rgb000
Copy link

rgb000 commented Feb 27, 2024

Hello.
We are facing with one strange behavior when generating GitHub Release. In Release we can see only features and bug fixes, but such types like ci, chore, build is not generated/present in Changelog and Release.
GitHub action workflow:

name: Releases
on:
  push:
    branches:
      - main

jobs:
  changelog:
    runs-on: ubuntu-latest
    permissions:
      contents: write
    steps:
      - uses: actions/checkout@v4

      - name: Conventional Changelog Action
        id: changelog
        uses: TriPSs/conventional-changelog-action@v5
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}

      - name: Create release Action
        uses: actions/create-release@v1
        if: ${{ steps.changelog.outputs.skipped == 'false' }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tag_name: ${{ steps.changelog.outputs.tag }}
          release_name: ${{ steps.changelog.outputs.tag }}
          body: ${{ steps.changelog.outputs.clean_changelog }}

Git log:

4c97fbc (tag: v1.2.0) chore(release): v1.2.0 [skip ci]
54069ef Merge pull request #20 from rgb000/feature/ip
83deb8c feat(ip): updated module outputs
b18eb82 feat: add ip module
97f3843 Merge pull request #19 from rgb000/feature/ci-update
5ed7a2e chore: updated pre-commit hooks
f3a70df chore: updated .gitignore

GitHub Release:
image

@TriPSs
Copy link
Owner

TriPSs commented Feb 27, 2024

This is because the default preset is 'angular' and that one does not contain those.

You could checkout one of the other presets, on my phone right know so can't link them.

@rgb000
Copy link
Author

rgb000 commented Feb 27, 2024

@rgb000
Copy link
Author

rgb000 commented Feb 27, 2024

Also I've tested rest of the types:

a28945b (HEAD -> main, tag: v1.5.0, origin/main, origin/HEAD) chore(release): v1.5.0 [skip ci]
f948072 Merge pull request #26 from rgb000/feature/test2
095e1b1 (origin/feature/test2, feature/test2) feat: message1
7a8a200 refactor: message1
470673a perf: message1
4f52413 docs: message1
5315945 build: message1
3e6cfbf Merge pull request #25 from rgb000/feature/test2
9cced26 ci: changed something
b285bd7 (tag: v1.4.0) chore(release): v1.4.0 [skip ci]

And from all of the above in Release I got only:

image

@TriPSs
Copy link
Owner

TriPSs commented Feb 27, 2024

Yes the type exists but they don't add it to the changelog, checkout the conventional commit one (search existing issues) I think that one does add them.

Otherwise it's an option to configure a custom config.

@TriPSs
Copy link
Owner

TriPSs commented Feb 27, 2024

See #217 for example.

@rgb000
Copy link
Author

rgb000 commented Feb 27, 2024

Yes, thanks. I found this information here - https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular

Could you please clarify how can I get common types (build, docs, perf, refactor, ci) in Changelog in this case ? Some example will be very appreciated

@TriPSs
Copy link
Owner

TriPSs commented Feb 27, 2024

By changing the preset to one that has it or using a custom config.

I'm on my phone so can't link/check, see issue that I referenced, I think that preset does it.

@rgb000
Copy link
Author

rgb000 commented Feb 27, 2024

I got the same results with mentioned preset ("conventionalcommits"). Please advice when you will be near PC

@TriPSs
Copy link
Owner

TriPSs commented Feb 28, 2024

Search for other preset that supports it, see also #223 or use a custom config.

@TriPSs TriPSs closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
@rgb000
Copy link
Author

rgb000 commented Feb 28, 2024

Hi.
I tried most of different presets and even custom config described here and didn't make it work as expected... As I saw in #254 issue conversation - we didn't get working config example as well....

@TriPSs
Copy link
Owner

TriPSs commented Feb 28, 2024

Please make a ticket at conventional commit library itself, that is what we use here, all of this is not related to this action.

Repository owner locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants