Merge pull request #1288 from egbertbouman/fix_dht_test

Fix pending task error in test_unload_while_contacting_node
Tribler · Mar 7, 2024 · 52d5add · 52d5add
2 parents cd5991e + 1040b54
commit 52d5add
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/pr-comment-validate.yml b/.github/workflows/pr-comment-validate.yml
@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: refs/pull/${{ github.event.issue.number }}/head
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.version }}
           cache: 'pip'

diff --git a/ipv8/test/dht/test_community.py b/ipv8/test/dht/test_community.py
@@ -221,8 +221,9 @@ async def test_unload_while_contacting_node(self) -> None:
         Test unloading nodes while contacting them.
         """
         await self.introduce_nodes()
-        ensure_future(self.overlay(0).find_nodes(self.key))  # noqa: RUF006
+        find_task = ensure_future(self.overlay(0).find_nodes(self.key))
         await self.overlay(0).unload()
+        await find_task
         self.assertTrue(self.overlay(0).request_cache._shutdown)  # noqa: SLF001
         self.assertTrue(self.overlay(0)._shutdown)  # noqa: SLF001