Fix _ez_unpack return type #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/ez_unpack_return_types
branch
from
366fd18
to
eb6bfa4
Compare
kozlovsky
commented
May 6, 2022
| # See https://stackoverflow.com/questions/54668000/type-hint-for-an-instance-of-a-non-specific-dataclass | ||
| __dataclass_fields__: dict | ||
| else: | ||
| DataclassPayload = type |
There was a problem hiding this comment.
As it turns out, protocols were added to typing in Python 3.8, so it is necessary to add this workaround for Python 3.7
qstokkink
added
the
priority: none
|
This PR has been open for 13 weeks without activity and it lacks sufficient motivation for its proposed changes. I will close this PR until the (equally inactive) discussion in #1094 has been concluded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1094
This PR:
EZPackOverlay._ez_unpack_authandEZPackOverlay._ez_unpack_noauth;DataclassPayloadtype.