Fixes for GUI emit interface mismatches

Tribler · Dec 17, 2020 · d0fd7d4 · d0fd7d4
1 parent f068b0f
commit d0fd7d4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/tribler-gui/tribler_gui/dialogs/confirmationdialog.py b/src/tribler-gui/tribler_gui/dialogs/confirmationdialog.py
@@ -52,7 +52,7 @@ def __init__(self, parent, title, main_text, buttons, show_input=False, checkbox
     def show_error(cls, window, title, error_text):
         error_dialog = ConfirmationDialog(window, title, error_text, [('CLOSE', BUTTON_TYPE_NORMAL)])
 
-        def on_close():
+        def on_close(checked):
             error_dialog.close_dialog()
 
         connect(error_dialog.button_clicked, on_close)
@@ -63,7 +63,7 @@ def on_close():
     def show_message(cls, window, title, message_text, button_text):
         error_dialog = ConfirmationDialog(window, title, message_text, [(button_text, BUTTON_TYPE_NORMAL)])
 
-        def on_close():
+        def on_close(checked):
             error_dialog.close_dialog()
 
         connect(error_dialog.button_clicked, on_close)

diff --git a/src/tribler-gui/tribler_gui/tribler_request_manager.py b/src/tribler-gui/tribler_gui/tribler_request_manager.py
@@ -80,7 +80,7 @@ def show_error(self, error_text):
             TriblerRequestManager.window, "Request error", main_text, [('CLOSE', BUTTON_TYPE_NORMAL)]
         )
 
-        def on_close():
+        def on_close(checked):
             error_dialog.close_dialog()
 
         connect(error_dialog.button_clicked, on_close)
@@ -211,7 +211,7 @@ def on_finished(self, request):
             else:
                 self.received_json.emit(json_result)
         except ValueError:
-            self.received_json.emit(None, self.reply.error())
+            self.received_error.emit(self.reply.error())
             logging.error("No json object could be decoded from data: %s" % data)
         finally:
             self.destruct()  # the request object should be properly destroyed no matter what

diff --git a/src/tribler-gui/tribler_gui/tribler_window.py b/src/tribler-gui/tribler_gui/tribler_window.py
@@ -484,7 +484,7 @@ def on_tribler_started(self, version):
 
         self.channels_menu_list.load_channels()
 
-    def stop_discovering(self):
+    def stop_discovering(self, response):
         if not self.discovering_page.is_discovering:
             return
         disconnect(self.core_manager.events_manager.discovered_channel, self.stop_discovering)

diff --git a/src/tribler-gui/tribler_gui/widgets/clickable_line_edit.py b/src/tribler-gui/tribler_gui/widgets/clickable_line_edit.py
@@ -6,7 +6,7 @@ class ClickableLineEdit(QLineEdit):
     """
     Represents a clickable QLineEdit widget.
     """
-    clicked = pyqtSignal()
+    clicked = pyqtSignal(bool)
 
     def mousePressEvent(self, event):
         self.clicked.emit(False)