-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement Request: Restructure of tribler-core
#6177
Comments
A couple of important notes:
In the end, it boils down to the classic question of "sort by type vs sort by function". Sort by type is the Unix's approach ( Which one fits Tribler better at this point in development, I'm unable to tell 🤷 |
@ichorid I've added "ledger zero" and "mds" ORM-bindings to the example above. |
We had a live discussion with @drew2a , and I am now convinced that this restructuring will do more good for Tribler immediately than it will do harm to our future modularisation goal. 👍 |
I've got an even more radical idea: let's just refactor everything properly with FastAPI+DependencyInjector |
The task is no longer relevant (after merging #6206). |
The current structure of
core
is definitely better than 7.3.0 but it is still far from perfection.I'm almost "one-year-tribler-developer" but still confused with the navigation and with the purpose of some folders.
I want to suggest one small step further.
The structure might look like this:
Why
rest
placed outside communities or components? Because it represents the whole Core-API and should be easy to find for those who want to use it.Why
database
placed outside ofmds
? Because it is one of the core Tribler's parts that has been used from several components and communities and deserves its place in a hi-level of the structure.Feel free to comments on a structure itself or on naming in particular.
When we will reach a consensus it will take one day of my time to implement the changes.
The text was updated successfully, but these errors were encountered: