Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.13.0-RC1] AssertionError aiohttp.web_request in __init__ #7344

Closed
sentry-for-tribler bot opened this issue Apr 3, 2023 · 5 comments
Closed

[7.13.0-RC1] AssertionError aiohttp.web_request in __init__ #7344

sentry-for-tribler bot opened this issue Apr 3, 2023 · 5 comments
Assignees
Milestone

Comments

@sentry-for-tribler
Copy link

sentry-for-tribler bot commented Apr 3, 2023

Sentry Issue: TRIBLER-12W

AssertionError: 
  File "aiohttp/web_protocol.py", line 505, in start
  File "aiohttp/web_app.py", line 446, in _make_request
  File "aiohttp/web_request.py", line 811, in __init__
  File "aiohttp/web_request.py", line 188, in __init__

https://github.com/aio-libs/aiohttp/blob/ae7703cefd1f8c8ad02bfc21cdc92c367f2666b9/aiohttp/web_request.py#L194-L195

        transport = self._protocol.transport
        assert transport is not None
@drew2a drew2a changed the title AssertionError aiohttp.web_request in __init__ [7.13.0-RC1] AssertionError aiohttp.web_request in __init__ Apr 3, 2023
@drew2a drew2a self-assigned this Apr 6, 2023
@drew2a drew2a added this to the 7.13.0 milestone Apr 6, 2023
@drew2a
Copy link
Collaborator

drew2a commented Apr 6, 2023

Could be related to #7345

@drew2a
Copy link
Collaborator

drew2a commented Apr 12, 2023

Could be somehow related to this issue: aio-libs/aiohttp#6978
They have a different described problem (Task exception was never retrieved) but the same initial stacktrace:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 505, in start
    request = self._request_factory(message, payload, self, writer, handler)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 446, in _make_request
    return _cls(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_request.py", line 811, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_request.py", line 188, in __init__
    assert transport is not None
AssertionError

We bumped aiohttp from version 3.8.1 to 3.8.3 on 04.11.2022.
Affected Tribler releases:

  1. 7.13.0-RC1

But regarding the Sentry, this bug was first seen in 7.12.1, which means our bug doesn't relate to the fact of bumping aiohttp from version 3.8.1 to 3.8.3:

image

@drew2a
Copy link
Collaborator

drew2a commented Apr 12, 2023

All events (one probable direction for further investigation — libtorrent rest component):

image

Another suspicious thing is the distribution of bug occurrence by Tribler's versions:

Version Downloads AssertionError count
v7.13.0-RC1 384 16
v7.12.1 108,125 4

@drew2a drew2a assigned kozlovsky and unassigned drew2a Apr 14, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
@kozlovsky
Copy link
Collaborator

I think the error is caused by the following bug in AIOHTTP: aio-libs/aiohttp#7258

kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 24, 2023
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Apr 25, 2023
kozlovsky added a commit that referenced this issue Apr 25, 2023
Fixes #7344: AssertionError "transport is not None" in aiohttp/web_request.py
xoriole pushed a commit to xoriole/tribler that referenced this issue May 8, 2023
Copy link
Author

Sentry issue: TRIBLER-1HZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants