Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tribler Android App #2476

Closed
wants to merge 644 commits into from
Closed

Tribler Android App #2476

wants to merge 644 commits into from

Conversation

brussee
Copy link
Member

@brussee brussee commented Jul 17, 2016

Build Status

Native Android app for Tribler with Java+xml GUI.
Using https://github.com/kivy/python-for-android to run Tribler python code as a native Android service.
The app communicates with the python service via the new rest api.

Also see: #2231

@whirm
Copy link
Contributor

whirm commented Jul 18, 2016

@brussee let's set up the build job to make sure everything is fine and dandy

@brussee brussee force-pushed the android-app branch 5 times, most recently from 06c2056 to d185db6 Compare July 19, 2016 14:54
@synctext
Copy link
Member

@brussee Please don't close this PR. It's indirectly referenced in a Tweakers post.

@brussee brussee force-pushed the android-app branch 2 times, most recently from 38da3d2 to c3d8c15 Compare July 20, 2016 15:57
@@ -100,7 +101,7 @@
</activity>
<activity
android:name=".BeamActivity"
android:label="@string/title_activity_beam"
android:launchMode="singleTop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you did forget it after all? :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are looking at the BeamActivity, not the MainActivity, but I indeed only had set it on SearchActivity before.

(bug was fixed)
*
*/

package org.kamranzafar.jtar;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than importing the code for a whole library as part of your sources, it may be more practical to have the build file take from an the jcenter and include it in your build.gradle

https://bintray.com/bintray/jcenter/org.kamranzafar%3Ajtar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly. However, the code has been modified during development for testing purposes. It was forked from the Python-for-Android repository originally.

@qstokkink
Copy link
Contributor

This PR has now diverged too much to still be considered for merging. That said, the Android app still lives on in other repositories without needing to be merged into this repository. As emotional of an experience as this may be, it is now time to close this PR.

@qstokkink qstokkink closed this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants