WIP: integrates bloom filter in tribler (from py-ipv8) #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
devos50
changed the title
|
oh whoops, i totally forgot to also add the tests from py-ipv8 for the bloom filter. Right now only the code itself is added (that is why coverage fails). Should i add now or wait until you figure out if it should be there at all / refactored (Tribler/py-ipv8#477) |
|
@devos50 as the market is still in, should we merge this now? |
|
@jonay2000 could you move the Bloomfilter class to the Also, I will remove the market implementation from Tribler and add the submodule instead as soon as possible. 👍 |
|
I am currently on holiday so I'll try to get it done by Monday. I'm sorry. |
|
Superseded by #4547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as i could see, this resolves all references to the bloom filter from pyipv8 and redirects them to an implementation in tribler. I am not completely sure where i should put it (it's in core now). Input is appreciated. As promised in Tribler/py-ipv8#477