Fix run tunnel helper #6292
Merged
Fix run tunnel helper #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
qstokkink
reviewed
Aug 25, 2021
| class IPAction(argparse.Action): | ||
| def __call__(self, parser, namespace, values, option_string=None): | ||
| try: | ||
| inet_aton(values) |
There was a problem hiding this comment.
Please consider using ipaddress.IPv4Address() instead of inet_aton(). This allows you to only catch AddressValueError exceptions (instead of general exceptions) and gives you a message that shows exactly what is wrong with the given IP address.
EDIT: this should probably not be part of this PR though.
There was a problem hiding this comment.
Thanks, will made another PR with this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
run_tunnel_helper.pyscripts so it can work with component architecture.It depends on #6291 and can be merged after #6291 is merged.