Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6263 #6354

Merged
merged 6 commits into from Sep 27, 2021
Merged

Fix #6263 #6354

merged 6 commits into from Sep 27, 2021

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Sep 24, 2021 •
edited

fixes #6263

Also, move osutils.py to tribler-common, since those functions are used by both GUI and Core

Also, fix some tests flaky ("ValueError: set_wakeup_fd only works in main thread") from not using pytest.mark.asyncio.

@ichorid
Copy link
Contributor Author

ichorid commented Sep 24, 2021

retest this please

@ichorid ichorid marked this pull request as ready for review September 24, 2021 15:01
@ichorid ichorid requested a review from a team as a code owner September 24, 2021 15:01
@ichorid ichorid requested review from drew2a and removed request for a team September 24, 2021 15:01
drew2a
drew2a previously approved these changes Sep 27, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@ichorid ichorid merged commit b59d6b6 into Tribler:main Sep 27, 2021
@ichorid ichorid deleted the fix_6263 branch September 27, 2021 09:51
@devos50 devos50 mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] Tribler gets stuck on loading screen after component crash
2 participants
@ichorid @drew2a