EVA: refactor the Transfer class
#6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
refactoring/eva_transfer
branch
4 times, most recently
from
002fbd2
to
d18413a
Compare
Move exceptions close to the top Remove unnecessary `message``field from exception Move EVAProtocol to the top of the file Remove obsolete TransferType Specify types for EVAProtocol constructor arguments Remove EVAProtocolMixin Add ipv8_message_handler Simplify the callback API Fix RemoteQueryCommunity Combine finish_with_result and finish_with_exception into a single method Move the future to the base Transfer class Fix send_binary docstring Fix misleading constant name: MAX_U64 -> MAX_U32 Remove unnecessary `updated` argument from Transfer constructor Rearrange Transfer arguments; remove block_count from Transfer constructor's argument Fix definitions of callback types Show exception class in RemoteQueryCommunity.on_error Fix incorrect warning in PyCharm Fix the argument type for EVAProtocol._resend_acknowledge_task() Move send_write_request from EVAProtocol to OutgoingTransfer Remove unnecessary send_write_request option from EVAProtocol, you can set retransmit_attempt_count to 0 instead Minor simplification of _send_write_request_task Remove IncomingTransfer._create_window() method Docstring fixes Restore retransmit_enabled flag Add protected _on_data_packet method for easier testing Return bool result from transfer.send_write_request() to simplify tests Fix EVA tests Codacy fixes Remove unused TransferWindow.last_window attribute Return send_write_request from OutgoingTransfer back to EVAProtocol Prevent "Future exception was never retrieved" error when the future is not used Extract make_protocol_decorator to use with different IPv8-based protocols Split finish args and remove nonce Add test_block_count_fits_a_single_window Remove _on_data_packet Move terminate_by_timeout_task Increase version Refactor test_termination_by_timeout
drew2a
force-pushed
the
refactoring/eva_transfer
branch
from
071c287
to
dd4a2c7
Compare
kozlovsky
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #6845