Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for the New Version Dialog #7101

Merged
merged 1 commit into from Oct 24, 2022
Merged

Refactoring for the New Version Dialog #7101

merged 1 commit into from Oct 24, 2022

Conversation

drew2a
Copy link
Collaborator

@drew2a drew2a commented Oct 21, 2022 •
edited

This PR adds a refactoring for #7077

image

The actions for the buttons are the following:

  1. Ignore: ignore this version at all. During the next Tribler run, all notifications about this version will be silently ignored.
  2. Later: ignore the version check for the current Tribler run.
  3. Ok: go to the Tribler website. The next version check will be performed 6 hours later.

@vi
Copy link
Contributor

vi commented Oct 21, 2022 •
edited

Note: also hacked up a simpler pull request about it: #7102. Not tested it though.

@vi vi mentioned this pull request Oct 21, 2022
Merged
@drew2a
Copy link
Collaborator Author

drew2a commented Oct 21, 2022

@vi thank you for contributing!
I've implemented an almost identical solution with a small refactoring.

:)

@drew2a drew2a force-pushed the fix/7077 branch 2 times, most recently from 7e8d667 to 711fb74 Compare October 21, 2022 13:41
@drew2a
Copy link
Collaborator Author

drew2a commented Oct 21, 2022

I've accepted and merged #7102
In this PR I left only refactoring.

@drew2a drew2a marked this pull request as ready for review October 21, 2022 13:45
@drew2a drew2a requested a review from a team as a code owner October 21, 2022 13:45
@drew2a drew2a requested review from kozlovsky and removed request for a team October 21, 2022 13:45
@drew2a drew2a changed the title Change behaviour of "later" button press in the New Version Dialog Refactoring for the New Version Dialog Oct 21, 2022
@drew2a drew2a mentioned this pull request Oct 21, 2022
Closed
@drew2a drew2a requested a review from xoriole October 24, 2022 08:25
xoriole
xoriole approved these changes Oct 24, 2022
View reviewed changes
src/tribler/gui/i18n/ru_RU.ts Show resolved Hide resolved
@drew2a drew2a merged commit 1a67ebb into Tribler:main Oct 24, 2022
@drew2a drew2a deleted the fix/7077 branch October 24, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

@kozlovsky kozlovsky Awaiting requested review from kozlovsky kozlovsky is a code owner automatically assigned from Tribler/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drew2a @vi @xoriole