Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added edit metadata GUI elements #7112

Merged
merged 1 commit into from Nov 1, 2022
Merged

Added edit metadata GUI elements #7112

merged 1 commit into from Nov 1, 2022

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Oct 27, 2022 •
edited

  • Added 'edit metadata' GUI elements.
  • Renamed various files and classes to reflect our new knowledge-based mechanism.

Closes #2455.

196442102-16ef039f-49b6-42b2-a4a0-8a6061cdedcb-2

@drew2a
Copy link
Collaborator

drew2a commented Oct 27, 2022

The calendar widget: https://doc.qt.io/qt-6/qtwidgets-widgets-calendarwidget-example.html

@drew2a
Copy link
Collaborator

drew2a commented Oct 27, 2022

Maybe it is possible to add the Language Dropdown from a web toolkit and render it via the QT WebEngine widget?
Like: https://coderthemes.com/ubold/layouts/default/dark.html

image

@devos50 devos50 force-pushed the edit_metadata_gui branch 3 times, most recently from f6b1490 to 190212a Compare October 31, 2022 09:48
@devos50
Copy link
Contributor Author

devos50 commented Oct 31, 2022 •
edited

I've added a drop-down menu for the language field:

Schermafbeelding 2022-10-31 om 10 49 34

Schermafbeelding 2022-10-31 om 10 49 30

These languages are source from this JSON file, which we include in our bundle. The language choice is stored as ISO 639-1 code in the underlying statement.

@devos50 devos50 marked this pull request as ready for review October 31, 2022 10:15
@devos50 devos50 requested a review from a team as a code owner October 31, 2022 10:15
@devos50 devos50 requested review from drew2a and removed request for a team October 31, 2022 10:15
drew2a
drew2a approved these changes Oct 31, 2022
View reviewed changes
src/tribler/gui/qt_resources/languages.json Outdated Show resolved Hide resolved
@devos50
Copy link
Contributor Author

devos50 commented Oct 31, 2022

retest this please

1 similar comment
@devos50
Copy link
Contributor Author

devos50 commented Oct 31, 2022

retest this please

@drew2a drew2a mentioned this pull request Oct 31, 2022
Closed
This was referenced Nov 1, 2022
Closed
Closed
Closed
@drew2a drew2a merged commit 1126f01 into Tribler:main Nov 1, 2022
@devos50 devos50 deleted the edit_metadata_gui branch November 1, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crowdsourcing Metadata
2 participants
@devos50 @drew2a