Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7253: Tribler does not run if the state directory does not already exist #7257

Merged
merged 2 commits into from Jan 16, 2023
Merged

Fix #7253: Tribler does not run if the state directory does not already exist #7257

merged 2 commits into from Jan 16, 2023

Conversation

kozlovsky
Copy link
Collaborator

This PR fixes #7253 by adding a possibility to specify the create=True option for get_root_state_directory().

The get_root_state_directory function now raises an exception if the state directory does not exist or is not a directory.

Also, the run_tribler_headless.py script was updated to use ProcessManager instead of the removed ProcessChecker.

@kozlovsky kozlovsky marked this pull request as ready for review January 13, 2023 12:23
@kozlovsky kozlovsky requested a review from a team as a code owner January 13, 2023 12:23
@kozlovsky kozlovsky requested review from drew2a and removed request for a team January 13, 2023 12:23
drew2a
drew2a previously approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drew2a drew2a dismissed their stale review January 13, 2023 14:49

GUI tests are failing

drew2a
drew2a requested changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. GUI tests are failing.

@drew2a drew2a mentioned this pull request Jan 14, 2023
Merged
@kozlovsky kozlovsky requested a review from drew2a January 16, 2023 13:34
@kozlovsky kozlovsky merged commit 906edaf into Tribler:main Jan 16, 2023
@kozlovsky kozlovsky deleted the fix/create_state_dir branch January 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tribler does not run if the state directory does not already exist
2 participants
@kozlovsky @drew2a