Fix and speed up health checks #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/health_check
branch
2 times, most recently
from
8f76c31
to
4bb25e6
Compare
drew2a
reviewed
Mar 8, 2023
src/tribler/core/components/metadata_store/db/orm_bindings/torrent_state.py
Outdated
Show resolved
Hide resolved
drew2a
reviewed
Mar 8, 2023
src/tribler/core/components/torrent_checker/torrent_checker/dataclasses.py
Show resolved
Hide resolved
drew2a
reviewed
Mar 8, 2023
src/tribler/core/components/torrent_checker/torrent_checker/dataclasses.py
Outdated
Show resolved
Hide resolved
drew2a
requested changes
Mar 8, 2023
kozlovsky
force-pushed
the
fix/health_check
branch
2 times, most recently
from
6963c1b
to
1393a70
Compare
drew2a
reviewed
Mar 9, 2023
src/tribler/core/components/torrent_checker/torrent_checker/dataclasses.py
Outdated
Show resolved
Hide resolved
drew2a
reviewed
Mar 9, 2023
src/tribler/core/components/torrent_checker/torrent_checker/dataclasses.py
Outdated
Show resolved
Hide resolved
kozlovsky
force-pushed
the
fix/health_check
branch
3 times, most recently
from
fd9b6a3
to
9307a1d
Compare
drew2a
reviewed
Mar 10, 2023
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py
Outdated
Show resolved
Hide resolved
drew2a
requested changes
Mar 10, 2023
kozlovsky
force-pushed
the
fix/health_check
branch
4 times, most recently
from
99311dc
to
5a359a5
Compare
…< operation with HealthInfo) and add default to it
…instead of TorrentState
…her); simplify health.should_update(prev_health)
kozlovsky
force-pushed
the
fix/health_check
branch
from
5a359a5
to
f10d2dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7287. There were several reasons for the bug:
last_checktimestamp value of 0.HealthInfo.should_update()were also incorrect, and the logic sometimes decided to keep the previous health info and not replace it with the new health info.Also, this PR fixes the long checking time by updating the torrent health immediately. Previously, TorrentChecker aggregated all results from all possible trackers before providing the new health info. Some trackers return result almost immediately, while other wait for up to 20 seconds. Because of this, all health checks previously took around 20 seconds, and now in many cases, they are updated almost immediately and then corrected with results from additional trackers if necessary.