Decrease the frequency of the downloads request
#7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
commented
Apr 19, 2023
| @@ -109,13 +118,16 @@ def start_loading_downloads(self): | |||
| self.loading_list_item = LoadingListItem(self.window().downloads_list) | |||
| self.window().downloads_list.addTopLevelItem(self.loading_message_widget) | |||
| self.window().downloads_list.setItemWidget(self.loading_message_widget, 2, self.loading_list_item) | |||
| self.schedule_downloads_timer(now=True) | |||
There was a problem hiding this comment.
It is not necessary to refresh the downloads on the Tribler start because they will be refreshed when the page is shown.
drew2a
requested review from
xoriole and
kozlovsky
and removed request for
a team
xoriole
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #7360 and should decrease the load by decreasing the frequency of the
downloadsrequest.Background refresh intervalhas been changed from1sto5s.Refresh now intervalhas been changed from0sto0.01s(https://doc.qt.io/qt-5/qtimer.html#start).This PR also offers an alternative solution for the problem addressed here: #7372