Fixes #7395 "Labels on Discovered channels are missing" #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7395. As it turns out, the result of the
QAbstractTableModel.headerDatamethod is expected to be a purestrinstance and not somestrsubclass (likeTranslatedString).It looks like in other places, Qt has no prejudice to str subclasses and renders them correctly.
But there is a slight chance we overlooked another place where the string is not rendered properly. For that reason, we can consider removing the
TranslatedStringsubclass. On the other side, it looks like it is currently handled correctly in all other places, and it gives protection against incorrectly translated stings, so we can continue to use it.