Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to call external scripts at certain places #22

Closed
GPMueller opened this issue Apr 2, 2018 · 4 comments
Closed

Add ability to call external scripts at certain places #22

GPMueller opened this issue Apr 2, 2018 · 4 comments
Labels
discussion Something that might end up being labled enhancement or wontfix

Comments

@GPMueller
Copy link
Contributor

  1. Before any target is parsed
  2. Before the build, i.e. before any target is compiled
  3. Before any target is linked
  4. After the build has finished

Specifying any Python script to be executed would suffice, as any configuration steps etc. (e.g. to create a header with version information) could be done well in Python.

@NOhs
Copy link
Collaborator

NOhs commented Apr 2, 2018

This is indeed a good idea. I am also considering adding functions in the classes in my branch like:

  • run_before
  • run_after_compile
  • run_after_linking

which are just empty functions. But then we could allow ppl to write custom targets that are derived from the default ones filling in those functions.

@NOhs NOhs added the discussion Something that might end up being labled enhancement or wontfix label Apr 2, 2018
@GPMueller
Copy link
Contributor Author

Added external scripting via targetname.scripts with fields before_compile, before_link and after_build in 79cc6bd.

@GPMueller
Copy link
Contributor Author

Added on master with 3d12899, including a test.

@GPMueller
Copy link
Contributor Author

Test passing since 47d3baa (OSX failed due to #30).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Something that might end up being labled enhancement or wontfix
Projects
None yet
Development

No branches or pull requests

2 participants