Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi release on every branch will lead to issues with pbr and its naming scheme #30

Closed
NOhs opened this issue Apr 15, 2018 · 4 comments
Closed
Labels
bug Something isn't working CI Everything related to build/test/deploy/analyse...

Comments

@NOhs
Copy link
Collaborator

NOhs commented Apr 15, 2018

pbr has the naming scheme version + commits since version. This can conflict for multiple branches. I also do not see the necessity to push every commit to pypi. I would limit it to the master branch. Most people will anyways only care for tagged releases.

@NOhs NOhs added bug Something isn't working CI Everything related to build/test/deploy/analyse... labels Apr 15, 2018
@GPMueller
Copy link
Contributor

This issue, so far, is specific to PR #23, where I also suggested a different tagging scheme in a comment. A commit-datetime tag is very unlikely to create collisions and gives the packages a chronological order. Do you think that would be sufficient?

@NOhs
Copy link
Collaborator Author

NOhs commented Apr 16, 2018

I don't see a need for pushing so many non-working versions to PyPi, it seems kind of not in the spirit of the PyPi system if everybody just pushes every possible commit to it. I mean, it is not meant as a back-up system of your commit history :D. I mean development release are fine, but not every commit?

@GPMueller
Copy link
Contributor

The non-working versions are of course not useful, but in general providing a develop version (and also also of feature branches) seems sensible to me.

@GPMueller
Copy link
Contributor

Fixed on PR #59, merged with 1bf1cb7 by disabling deployments on non-master branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Everything related to build/test/deploy/analyse...
Projects
None yet
Development

No branches or pull requests

2 participants