Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive cloning of git submodules #62

Closed
GPMueller opened this issue Aug 31, 2018 · 1 comment · Fixed by #88
Closed

Recursive cloning of git submodules #62

GPMueller opened this issue Aug 31, 2018 · 1 comment · Fixed by #88
Labels
enhancement New feature or request

Comments

@GPMueller
Copy link
Contributor

Nanogui is a good example of nice usage of submodules. We should either recursively clone by default (there may be arguments against this) or provide an easy way to specify that it is required, e.g. git_submodules = True.
@GPMueller GPMueller added the enhancement New feature or request label Aug 31, 2018
@GPMueller
Copy link
Contributor Author

As no arguments against recursive cloning by default have been brought up, I believe it would be the best approach, together with the ability to specify recursive_clone = false.

@GPMueller GPMueller mentioned this issue Aug 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added recursive cloning of git submodules. Trick-17/clang-build
1 participant
@GPMueller