Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed list mangling #80

Merged
merged 5 commits into from Sep 14, 2019
Merged

Removed list mangling #80

merged 5 commits into from Sep 14, 2019

Conversation

NOhs
Copy link
Collaborator

@NOhs NOhs commented Aug 14, 2019

Regarding #74, this merge request removes most occurences of set where we might want to preserve the order. Compile flags for sure need the order preserved. For the include paths I think it shouldn't be advertised, but for debugging purposes it is better if the include paths are in a somewhat reasonable order.

@NOhs NOhs requested a review from GPMueller August 14, 2019 23:24
@NOhs NOhs self-assigned this Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #80 into master will decrease coverage by 1.76%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage      81%   79.23%   -1.77%     
==========================================
  Files          12       12              
  Lines         979      992      +13     
==========================================
- Hits          793      786       -7     
- Misses        186      206      +20
Impacted Files Coverage Δ
clang_build/target.py 89.76% <100%> (-0.16%) ⬇️
clang_build/io_tools.py 93.4% <100%> (-6.6%) ⬇️
clang_build/project.py 72.47% <66.66%> (+0.64%) ⬆️
clang_build/platform.py 68.18% <0%> (-29.55%) ⬇️
clang_build/clang_build.py 68.98% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70bd03...2772f6b. Read the comment docs.

@NOhs
Copy link
Collaborator Author

NOhs commented Aug 21, 2019

This should be ready for merging now.

@NOhs
Copy link
Collaborator Author

NOhs commented Aug 21, 2019

I think the OSX CI is still broken, it reports everything runs fine, but it is missing in the coverage report I think.

@GPMueller
Copy link
Contributor

GPMueller commented Aug 21, 2019

To be honest I don't quite understand how the Travis tests are running through if Python 3.7 really is a requirement, since on the Linux VMs, only Python 3.6 is available:

clang-build/.travis.yml

Lines 8 to 11 in 890b0a6

- language: python
os: linux
env: DEPLOY=true
python: 3.6

Changing it to 3.7 is apparently not possible yet.

@NOhs
Copy link
Collaborator Author

NOhs commented Sep 14, 2019

I'll merge for now, while we look for a way to support OSX CI in the future.

@NOhs NOhs merged commit 07ffff2 into master Sep 14, 2019
@GPMueller GPMueller deleted the removed_list_mangling branch September 16, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants