New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed list mangling #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 81% 79.23% -1.77%
==========================================
Files 12 12
Lines 979 992 +13
==========================================
- Hits 793 786 -7
- Misses 186 206 +20
Continue to review full report at Codecov.
|
This should be ready for merging now. |
I think the OSX CI is still broken, it reports everything runs fine, but it is missing in the coverage report I think. |
To be honest I don't quite understand how the Travis tests are running through if Python 3.7 really is a requirement, since on the Linux VMs, only Python 3.6 is available: Lines 8 to 11 in 890b0a6
Changing it to 3.7 is apparently not possible yet.
|
I'll merge for now, while we look for a way to support OSX CI in the future. |
Regarding #74, this merge request removes most occurences of
set
where we might want to preserve the order. Compile flags for sure need the order preserved. For the include paths I think it shouldn't be advertised, but for debugging purposes it is better if the include paths are in a somewhat reasonable order.