Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference engine - Add new bridge bidding bot. #216

Closed
wants to merge 74 commits into from

Conversation

RalphLipe
Copy link
Contributor

No description provided.

Various fixes to Jacoby Transfers and new test files.  Basic transfer logic working.
All transfer tests work properly.  Now need to implement Stayman as a state machine.
More tests.   All NT conventions now using state machine.  Still needs lots of cleanuo
More cases are working.  Now have 2NT tests.  Stayman and transfers are working properly for basic cases.  All using state machine call-backs.

Lots remains to be done - interference needs to be considered at each step.
Also implemented basic 1NT overcall test
Added new test for Stayman.  Cleaned up Stayman.cs.  Moved non-conventional bids into NoTrump class
Removed ranges from NT and moved to an enum that describes various ranges.  First attempt at slam bids.
Now 5/4 invitational hands work per SAYC bidding.  Additional regression tests pass.
Was using old ranges for points.  Changed to Non-Forcing bid function.
Cappelletti is not part of SAYC.  Did not remove file, but removed all calls to it.  Added new test for simple NT overcalls
Added PointsAdjustment call to bids.  Dummy computation requires a suit.
All code should now be in NoTrump.cs.
Prototype code for a new way to represent bid rules as a series of constraints.  The rules can update a global summary state, and examine that summary state in subsequent bids.
Still a major work in progress, but huge changes so I an committing.
Still lots to do, and hack implementaitons, but basic bidding is actually working now.
The most basic of basic tests are working.
Fixed several bugs.  Implemented contract.  Bid validation over a contract.  JumpBid constraint.
Most stayman tests now work.  PBN tests plugged into hacked test infrastructue.
Did a lot of cleanup on NT conventions.  Have HCP as its own value in HandSummary.  Can use StartingPoints and HighCardPoints together to make decisions
RalphLipe and others added 22 commits July 29, 2023 23:08
Still more cleanup - lots to do.  But get it on my desktop...
Still lots of cleanup to do but more basic bidding tests passing.
Now its just a matter of making them all work...
Almost everything except for doubles (both penalty and takeout) is working correctly.
Hacked to let webui work with new bot
And use RLBot by default in test suite.
Update inference engine to run conditionally
@antross
Copy link
Member

antross commented Dec 8, 2023

@RalphLipe let me know once you've finished removing the remaining dependencies on TricksterBotClasses.

I've put together a test project using .NET Standard 2.0 (.NET 8 for tests) that I'll help migrate this to. That'll enable folks to test/contribute from other OSes like Macs. I'll also move everything to a separate repository at that point so we can have dedicated issue/code management for this project apart from the other bots.

@RalphLipe
Copy link
Contributor Author

RalphLipe commented Dec 8, 2023 via email

Introduced the BridgeBidding namespace and the BridgeBidder class.  All dependencies on Trickster classes have been removed.  Now the bidding bot can be moved to a completely independent project.
Check to see if opening bid was No Trump before applying logic for takeout double.
One more test passes, and a new one breaks.  Not 100% sure if new break is really an incorrect test.  Blackwood advance now works properly though.
@antross
Copy link
Member

antross commented Jan 10, 2024

This has been moved to our Bridgit repository.

@antross antross closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants