Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish i18n (mostly Sawbench UI) and update ru_RU.lang #83

Merged
merged 2 commits into from Nov 5, 2019
Merged

Finish i18n (mostly Sawbench UI) and update ru_RU.lang #83

merged 2 commits into from Nov 5, 2019

Conversation

PolyacovYury
Copy link
Contributor

  • Sawbench GUI title, "%s makes %s" and page names are now internationalised
  • "Cut from: " in shapes' tooltips is now internationalised
  • Fixed capitalisation in Ioniс and Corinthian Capitals' names
  • Updated ru_RU.lang

- Sawbench GUI title, "%s makes %s" and page names are now internationalised
- "Cut from: " in shapes' tooltips is now internationalised
- Fixed capitalisation in Ioniс and Corinthian Capitals' names
- Updated ru_RU.lang
@darkevilmac
Copy link
Contributor

darkevilmac commented Nov 4, 2019 via email

- ShapePage now has a translationKey instead of title and provides a getLocalizedName() method
- updated and rearranged translation strings for shape pages
@PolyacovYury
Copy link
Contributor Author

you should move the tooltips together in the English language file

As far as I can tell - there are only three tooltip texts which are right next to each other. The "ratio" is not a tooltip, it's a separate line in GUI. Correct me, if I am missing something, please.

the shape pages should have the full localization string built into the class. This also means the field for the name should be changed to match EnumShape and have a method inside of the class to get the localized name.

Done. At least as much as I understood you wanted me to do.

@darkevilmac darkevilmac merged commit f103475 into TridentMC:1.12 Nov 5, 2019
@PolyacovYury PolyacovYury deleted the lang_fixes branch November 6, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants