Low volume spacing fix #41
Conversation
…rtrap-ios into compiler-warning-cleanups # Conflicts: # TriggertrapSLR/TimelapseProViewController.swift
…eanups Compiler warning cleanup
…s into release-4.1.4
There was a problem hiding this comment.
@alex-taffe this looks good. Just the one comment in the code.
Also, I've noticed that these changes cause the title in the notification to become left-aligned rather than entered, and it looks like the weight of the font has changed too. Are we able to use the original design?
| self.notification?.duration = 2.0 | ||
| self.notification?.show() | ||
| //this needs to be reinstantiated each time to avoid glitchy behavior (sadly) | ||
| self.notification = MPGNotification(title: NSLocalizedString("Low Volume", comment: "Low Volume"), |
There was a problem hiding this comment.
@alex-taffe can you explain a bit more the reasoning for this? What exactly is the "glitchy behaviour" and how does this resolve it?
Also, why have we removed the check for isAnimating, will that not cause multiple notifications to stack on-top of each other?
|
@Ross-Gibson without the reinstantiation I get this weird bug. I’m not really sure why and I've messed around with the threading for awhile to see if that’s the issue, but I honestly don't know As for the is animating, that property does not exist anymore in the library (as of the iPhone X fix). There is a As for the design, also part of the library change. Lemme look into it more |
|
@Ross-Gibson I got everything fixed minus the instantiation problem, which I have no idea how to fix |
This includes changes from #38 and should not be merged until then
Also, I removed MPGNotification from the actual project and changed it to a cocoa pod. The newer version has support for iPhone X so that was most of our issue, but it’s also just good to get it out of the project. You’ll need to run a
pod update; pod installbefore this compiles most likelyFixes #26