Improved the RSAT installation process #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamErde
reviewed
Jan 11, 2024
| .EXAMPLE | ||
| Test-IsElevated | ||
| #> | ||
| if (-not(Get-Module -Name 'ActiveDirectory' -ListAvailable)) { |
There was a problem hiding this comment.
The -not condition here flips your if/true logic. Just need to either remove -net or swap your $true and $false outputs. :)
There was a problem hiding this comment.
I agree with Sam here. Instead of having a -not here and a -not in the public Invoke-Locksmith function:
I'd rather both -nots be removed. It makes the logic easier to understand.
TrimarcJake
requested changes
Jan 13, 2024
| .EXAMPLE | ||
| Test-IsElevated | ||
| #> | ||
| if (-not(Get-Module -Name 'ActiveDirectory' -ListAvailable)) { |
There was a problem hiding this comment.
I agree with Sam here. Instead of having a -not here and a -not in the public Invoke-Locksmith function:
I'd rather both -nots be removed. It makes the logic easier to understand.
TrimarcJake
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this issue I created two new functions:
TestIsRSATInstalledwhich returns true if the RSAT AD PowerShell module is installed or false if notInstallRSATADPowerShellwhich installs the RSAT AD PowerShell moduleInvoke-Locksmithnow has a simple check for the RSAT AD PowerShell module and calls the install function when needed.Please let me know if you see/experience any issues testing this. "It works on my system." :D