Add support for cancelation of builds with snapshot dependencies #78
+125
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this, quick question. now by default for each push for example on a Pull request the hook will send several more rest requests to teamcity to find the dependencies right? if this is the case, we have some network constraints and our infra will start bothering us why we are sending more http requests from the application... Can this be a opt in option? We don't really use dependencies so the extra requests just slows us down |
|
If the target build doesn't have any dependencies, it will be one more request to TeamCity. |
In the current state, the plugin assumes that if a target build in the queue it will always run the latest revision and will not try to cancel it. This is not always the case for builds with snapshot dependency. Based on the teamcity configuration, a snapshot dependencies can enforce the revision of a queued build if one of the dependencies has already started For example: Triggering a build A with a snapshot dependency B configured with "Enforce revisions synchronization". As soon as B leave the queue, it will enforce the revision on the build A, if the VCS root is the same for both builds The plugin now will ensure the revision of the target build is correct before skipping it and will with an opt-in option cancel any non reused dependencies.
arnaudmathias
force-pushed
the
snapshot-dependencies-support
branch
from
178999e
to
2f63723
Compare
jmecosta
approved these changes
Oct 10, 2021
|
release https://marketplace.atlassian.com/manage/apps/1215178/versions/300000280/details thanks for this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state, the plugin assumes that if a target build in the queue, it will always run the latest revision and will not try to cancel it.
This is not always the case for builds with snapshot dependency.
Based on the teamcity configuration, a snapshot dependencies can enforce the revision of a queued build if one of the dependencies has already started
For example:
Triggering a build A with a snapshot dependency B configured with "Enforce revisions synchronization".
As soon as B leave the queue, it will enforce the revision on the build A, if the VCS root is the same for both builds
The plugin now will ensure the revision of the target build is correct before skipping it and will cancel any non reused dependencies.