Skip to content

Commit

Permalink
DB/Disables: Add "Stoneclaw Totem TEST" spell to the disables table. C…
Browse files Browse the repository at this point in the history 
…loses #2818 & #2232
  • Loading branch information
@DDuarte
DDuarte committed Sep 1, 2011
1 parent 68037cd commit 0046083
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sql/updates/world/2011_09_01_00_world_disables.sql
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
DELETE FROM `disables` WHERE `sourceType`=0 AND `entry`=23789;
INSERT INTO `disables` (`sourceType`, `entry`, `flags`, `comment`) VALUES
(0, 23789, 8, 'Stoneclaw Totem TEST - can crash client by spawning too many totems');

9 comments on commit 0046083

@Aristoo
Copy link
Contributor

@Aristoo Aristoo commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.wowhead.com/spell=61904 have same effect

@Warpten
Copy link
Member

@Warpten Warpten commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess they failed at writing -1

@DDuarte
Copy link
Contributor Author

@DDuarte DDuarte commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess they failed at writing -1

214748364 != 2147483647

@Warpten
Copy link
Member

@Warpten Warpten commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pwnd x)

@kroolik
Copy link

@kroolik kroolik commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question: Is there any NPC or GO that is ever casting a TEST spell? I know that something with TEST attracts people' attention just like red button signed "Do not touch", but they do that on their own responsibility.

@Warpten
Copy link
Member

@Warpten Warpten commented on 0046083 Sep 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to prevent spells from being cast if they summon too many creatures, like this one does ? I mean, not using single disables entry, rather using a generic check.

@dbrown1986
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The realization is that Blizzard included these spells to test builds and servers before release, making sure everything works, sure a private server isn't going to hand spawning some 214 million totems (no joke), but perhaps Blizzards servers can. Still, good to disable so it isn't mistakenly added by a GM who doesn't know what it does.

@Aokromes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure that spell on retail don't spawns 214 millon of totems instead does something else non-handled by trinity's spell system.

@Warpten
Copy link
Member

@Warpten Warpten commented on 0046083 Sep 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By any chance, it does print a trollface. [/unrelated comment]

Please sign in to comment.