Core/SAI: Fix an issue where SAI was ignoring civilian and passive un…

…it flags Closes #2526 Disclaimer: This was not thoroughly tested; report any issue caused by this change.
TrinityCore · Oct 1, 2011 · 0f7d9e4 · megamage · Oct 3, 2011 · DDuarte
1 parent 269274f
commit 0f7d9e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/server/game/AI/SmartScripts/SmartAI.cpp b/src/server/game/AI/SmartScripts/SmartAI.cpp
@@ -469,6 +469,9 @@ void SmartAI::MoveInLineOfSight(Unit* who)
 
     if (!CanAIAttack(who))
         return;
+
+    if (!me->canStartAttack(who, false))
+        return;
 
     if (me->IsHostileTo(who))
     {
@@ -487,9 +490,6 @@ void SmartAI::MoveInLineOfSight(Unit* who)
             }
         }
     }
-
-    //if (me->canStartAttack(who, false))
-    //    AttackStart(who);
 }
 
 bool SmartAI::CanAIAttack(const Unit* /*who*/) const

diff --git a/src/server/game/Grids/Notifiers/GridNotifiers.h b/src/server/game/Grids/Notifiers/GridNotifiers.h
@@ -1025,15 +1025,11 @@ namespace Trinity
                     return false;
 
                 if (m_force)
-                {
                     if (!me->IsValidAttackTarget(u))
                         return false;
-                }
                 else
-                {
                     if (!me->canStartAttack(u, false))
                         return false;
-                }
 
                 m_range = me->GetDistance(u);   // use found unit range as new range limit for next check
                 return true;