Skip to content

Commit

Permalink
DB/Schema: rename ip2nationcountries to ip2nationCountries (Linux)
Browse files Browse the repository at this point in the history 
Closes #8947
Thanks Vincent
  • Loading branch information
@DDuarte
DDuarte committed Jan 14, 2013
1 parent c9ec5b4 commit 5844ad5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sql/updates/world/2013_01_14_02_world_ip2nationcountries.sql
View file
@@ -0,0 +1,2 @@
RENAME TABLE ip2nationcountries TO ip2nationcountries_temp,
ip2nationcountries_temp TO ip2nationCountries;

6 comments on commit 5844ad5

@limcross
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, directly?

RENAME TABLE ip2nationcountries TO ip2nationCountries;

@DDuarte
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because silly Windows is case insensitive:

A SQL error occured (1050): Table 'ip2nationcountries' already exists

(Notice that no query can change the name to ip2nationCountries on Windows (works fine on linux with either query))

@chaosua
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the best to edit table name in core to lowercase like other table names...?

@DDuarte
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's an external table, not maintained by us

@unnamed-zz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh thanks...

@fdns
Copy link

@fdns fdns commented on 5844ad5 Jan 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DDuarte And that is why we hate windows :)

Please sign in to comment.