Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Core/Spells: Fix Aspect of the Beast
- Loading branch information
Showing
4 changed files
with
60 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
DELETE FROM `spell_script_names` WHERE `spell_id`=13161; | ||
INSERT INTO `spell_script_names` (`spell_id`,`ScriptName`) VALUES | ||
(13161, 'spell_hun_aspect_of_the_beast'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d0a2b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @kapoeira
5d0a2b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to QAston for his tip about the unit flag and Shauren by giving a hint I couldn't exploit since I didn't know how to exploit it the good way :p
5d0a2b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Why do you call 'GetCaster' twice ?)
5d0a2b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the typo.
About GetCaster() it's an old habit, true i could use:
But the difference is nearly non existent.
5d0a2b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or
if (Unit* caster = GetCaster())
if (caster->ToPlayer())
if (...)
...
And for the typo, I think it should be :
if (Pet* pet = caster->ToPlayer()->GetPet())
pet->CastSpell(...)
And not
caster->CastSpell(...)
at line 80.
And thank you for your work !
EDIT: I finaly understood this part, you are right !