Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Core/Startup: Warn when a config key isn't found in the config files
Example: "Missing name Guild.SaveInterval in config file worldserver.conf, add "Guild.SaveInterval = 15" to this file" (cherry picked from commit 06b3bca) # Conflicts: # src/common/Configuration/Config.cpp
- Loading branch information
Showing
1 changed file
with
36 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6487e2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that the key it's trying to find is missing from the cobf file? ptree_bad_data sounds like a malformatted value or similar (e.g wrong type). Which one is responsible for this specific crash? I'll check this later.
6487e2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A copy of your conf file can help. I think that it should crash/error on bad_data but not on bad_path.
6487e2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question still stands, do we want it to crash or catch the exception and log the error?
6487e2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catch the exception and log imo...since afaik all conf variables have defaults hardcoded.
6487e2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9431b94