Skip to content

Commit

Permalink
Core/Spells: rename MECHANIC_PACIFY to MECHANIC_SLOW_ATTACK and fix a…
Browse files Browse the repository at this point in the history
… bug with Frost Fever removing by PvP trinket

Closes #457 & #836 & #1195
  • Loading branch information
tobmaps committed May 11, 2011
1 parent 7b0db7a commit 8ecde2f
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/server/game/Miscellaneous/SharedDefines.h
Expand Up @@ -1186,7 +1186,7 @@ enum Mechanics
MECHANIC_FEAR = 5,
MECHANIC_GRIP = 6,
MECHANIC_ROOT = 7,
MECHANIC_PACIFY = 8, //0 spells use this mechanic
MECHANIC_SLOW_ATTACK = 8,

This comment has been minimized.

Copy link
@Jildor

Jildor Nov 24, 2017

Contributor

btw, wiki needs to be updated 😄

This comment has been minimized.

Copy link
@Killyana

Killyana Nov 24, 2017

Member

It's up to date: 128 | 0x0000 0080 | MECHANIC_SLOW_ATTACK

This comment has been minimized.

Copy link
@Jildor

Jildor Nov 24, 2017

Contributor

Look at the history and tell me who made the change 😄

MECHANIC_SILENCE = 9,
MECHANIC_SLEEP = 10,
MECHANIC_SNARE = 11,
Expand All @@ -1212,14 +1212,14 @@ enum Mechanics
MECHANIC_ENRAGED = 31
};

// Used for spell 42292 Immune Movement Impairment and Loss of Control (0x49967da6)
// Used for spell 42292 Immune Movement Impairment and Loss of Control (0x49967ca6)
#define IMMUNE_TO_MOVEMENT_IMPAIRMENT_AND_LOSS_CONTROL_MASK (\
(1<<MECHANIC_CHARM)|(1<<MECHANIC_DISORIENTED)|(1<<MECHANIC_FEAR)| \
(1<<MECHANIC_ROOT)|(1<<MECHANIC_PACIFY)|(1<<MECHANIC_SLEEP)| \
(1<<MECHANIC_SNARE)|(1<<MECHANIC_STUN)|(1<<MECHANIC_FREEZE)| \
(1<<MECHANIC_KNOCKOUT)|(1<<MECHANIC_POLYMORPH)|(1<<MECHANIC_BANISH)| \
(1<<MECHANIC_SHACKLE)|(1<<MECHANIC_TURN)|(1<<MECHANIC_HORROR)| \
(1<<MECHANIC_DAZE)|(1<<MECHANIC_SAPPED))
(1<<MECHANIC_ROOT)|(1<<MECHANIC_SLEEP)|(1<<MECHANIC_SNARE)| \
(1<<MECHANIC_STUN)|(1<<MECHANIC_FREEZE)|(1<<MECHANIC_KNOCKOUT)| \
(1<<MECHANIC_POLYMORPH)|(1<<MECHANIC_BANISH)|(1<<MECHANIC_SHACKLE)| \
(1<<MECHANIC_TURN)|(1<<MECHANIC_HORROR)|(1<<MECHANIC_DAZE)| \
(1<<MECHANIC_SAPPED))

// Spell dispell type
enum DispelType
Expand Down

5 comments on commit 8ecde2f

@Warpten
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also check that this define you modified was not used elsewhere ? just wondering.

@tobmaps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofc i checked before push

@AwkwardDev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tobmaps, knows his work very well xD.

@efstan
Copy link

@efstan efstan commented on 8ecde2f Aug 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does that close 1195?

@tobmaps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because those links comes from old TC issue tracker, numeration was recalculated for github

Please sign in to comment.