Skip to content

Commit

Permalink
Core/Scripts Implemented Boss Ahune
Browse files Browse the repository at this point in the history 
Implemented Midsummer Fire Festival event Boss, Ahune
  • Loading branch information
@sirikfoll
sirikfoll committed Mar 4, 2016
1 parent f46a0e7 commit 99df5f4
Show file tree
Hide file tree
Showing 5 changed files with 1,512 additions and 6 deletions.

8 comments on commit 99df5f4

@Naios
Copy link
Contributor

@Naios Naios commented on 99df5f4 Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirikfoll @DDuarte

This commit introduces 2 warnings:

[ 40%] Building CXX object src/server/scripts/CMakeFiles/scripts_outland.dir/Outland/CoilfangReservoir/TheSlavePens/instance_the_slave_pens.cpp.o
[ 41%] Built target scripts_world
/var/lib/jenkins/jobs/tc_335_release_clang36/workspace/src/server/scripts/Outland/CoilfangReservoir/TheSlavePens/instance_the_slave_pens.cpp[ 41%] :84:14: fatal error: 'SetGuidData' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        void SetGuidData(uint32 data, ObjectGuid guid)
             ^
/var/lib/jenkins/jobs/tc_335_release_clang36/workspace/src/server/game/Maps/ZoneScript.h:45:22: note: overridden virtual function is here
        virtual void SetGuidData(uint32 /*DataId*/, ObjectGuid /*Value*/) { }
                     ^
Building CXX object src/server/scripts/CMakeFiles/scripts_outland.dir/Outland/CoilfangReservoir/TheSlavePens/boss_rokmar_the_crackler.cpp.o
[ 43%] Built target scripts_spells
[ 44%] Building CXX object src/server/scripts/CMakeFiles/scripts_outland.dir/Outland/CoilfangReservoir/TheSlavePens/boss_ahune.cpp.o
/var/lib/jenkins/jobs/tc_335_release_clang36/workspace/src/server/scripts/Outland/CoilfangReservoir/TheSlavePens/boss_ahune.cpp:891:14: fatal error: 'Register' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        void Register()
             ^
/var/lib/jenkins/jobs/tc_335_release_clang36/workspace/src/server/game/Spells/SpellScript.h:125:22: note: overridden virtual function is here
        virtual void Register() = 0;

@wonder2011
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is possible to integrate this code with the 4.3.4 core?

@DDuarte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have one...

@wonder2011
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well i have a 4.3.4 trinity source, from wowsource.info, is possible to integrate this without crash the server ?

@DDuarte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not related to Trinity. I don't know why you are asking about it on this repo.

@wonder2011
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i'm new to this world and i don't have much knoledge of how this work. I have the goal of help, sorry if i do or say something wrong.

@DDuarte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np, welcome. You can start with https://trinitycore.atlassian.net/wiki/display/tc/Installation+Guide

@wonder2011
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, sorry for the comments then.

Please sign in to comment.