Skip to content

Commit

Permalink
DB/SAI: Convert 28.236 smart_scripts (almost all, like 20 left behind…
Browse files Browse the repository at this point in the history 
…) to proper commenting. Used this tool: https://github.com/Discover-/SAI-Comment-Converter
  • Loading branch information
Discover- committed Dec 20, 2013
1 parent eb57c4f commit 9ac96fd
Showing 1 changed file with 28,237 additions and 0 deletions.

9 comments on commit 9ac96fd

@JasperAppec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple example as to why this is useful...

Old:

On spell hit run script

New:

Maiden of Winter's Breath Lake - On Spellhit 'Break Curse of Ice' - Run Script

@Pirricli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Faq
Copy link
Contributor

@Faq Faq commented on 9ac96fd Dec 20, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool bro 💯

@Exodius
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@JasperAppec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor mistake made for INC_EVENT_PHASE, fixing asap.

@cooler-SAI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be apply my scripts what missed in DB and then add your commits ? xD https://github.com/cooler-SAI/patch/commit/eba9039d558945b1e4a7e674ac8f39d480e2931e
Big Balls - Big Man!)) good tool

@filipboev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this disgusting as it overwrites things that I have done like "Die die die - on spell hit - you".
Dumb joke aside, good job big boy.

@JasperAppec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Fixing asap' means I'll do it when I have time, and that's not for any of the coming hours. :p

@JasperAppec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 42a365a.

Please sign in to comment.