Skip to content

Commit

Permalink
Core/Spells: Malleable Goo need be negative
Browse files Browse the repository at this point in the history 
Closes #22757
  • Loading branch information
@Keader
Keader committed Jan 4, 2019
1 parent 74d51b9 commit 9ecce33
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/server/game/Spells/SpellInfo.cpp
View file
Expand Up @@ -3406,6 +3406,10 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, uint8 effIndex, std::unor
case 64412: // Phase Punch, Algalon the Observer, Ulduar
case 72410: // Rune of Blood, Saurfang, Icecrown Citadel
case 71204: // Touch of Insignificance, Lady Deathwhisper, Icecrown Citadel
case 70853: // Malleable Goo, Professor Putricide (10 normal)
case 72458: // Malleable Goo, Professor Putricide (25 normal)
case 72873: // Malleable Goo, Professor Putricide (10 heroic)
case 72874: // Malleable Goo, Professor Putricide (25 heroic)
return false;
case 24732: // Bat Costume
case 30877: // Tag Murloc
Expand Down

6 comments on commit 9ecce33

@jackpoz
Copy link
Member

@jackpoz jackpoz commented on 9ecce33 Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come current checks return true instead ?

@Killyana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of debuff are not negative after last changes on spells, I don't think this is the correct way to fix this spells.

@Killyana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An other one #22840

@jackpoz
Copy link
Member

@jackpoz jackpoz commented on 9ecce33 Jan 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keader could you investigate a bit further into this to find a better generic solution ?

@Keader
Copy link
Member Author

@Keader Keader commented on 9ecce33 Jan 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i have time today.
I was just following ariel-, he fixed some issues with this way.
But i agree with you, need have a better way to make those spells negative.

@Keader
Copy link
Member Author

@Keader Keader commented on 9ecce33 Jan 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive is it @jackpoz (a0de602)

Please sign in to comment.