Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Quest Bug} Brains! Brains! Brains! #10244

Closed
novos opened this Issue Jul 7, 2013 · 4 comments

Comments

Projects
None yet
6 participants
@novos
Copy link

commented Jul 7, 2013

Hello everyone,

I have encountered a problem in the quest Brains! Brains! Brains!

The problem is you can spam quest item on the same corpse and it wont automatically disappear making the quest super easy!

Quest - http://www.wowhead.com/quest=11301/brains-brains-brains
Quest Item - http://www.wowhead.com/item=33554

TDB - 335.51
Hash - 0e4cebf
Linux SQL

Thanks for help.

@lolgubstep

This comment has been minimized.

Copy link

commented Jul 15, 2013

Confirmed. This problem is ancient.

@Justiciar

This comment has been minimized.

Copy link

commented Sep 7, 2013

I fixed it.
I also fixed the conditions of the spell which allowed to use this item and get the credit from any creature and on the Deranged Explorer while it was alive.
The conditions I set fixed those issues^.
The Deranged Explorer now despawn after using the quest item on him, which makes it impossible to use the quest item twice on the same npc.

My Fix:

SET @GRICKSBONESAW     :=43286;
SET @DERANGEDEXPLORER  :=23967;
SET @NPC_REWARD        :=23967;

DELETE FROM `conditions` WHERE `SourceEntry`=@GRICKSBONESAW AND `SourceTypeOrReferenceId`=17;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES
(17,0,@GRICKSBONESAW ,0,0,36,1,0,0,0,1,0,'', 'Gricks Bonesaw can target only a corpse'),
(17,0,@GRICKSBONESAW ,0,0,31,1,3,@DERANGEDEXPLORER,0,0,0,'', 'Gricks Bonesaw can target only Deranged Explorer');
UPDATE `creature_template` SET `AIName`='SmartAI' WHERE `entry` = @DERANGEDEXPLORER; 
DELETE FROM `smart_scripts` WHERE `entryorguid` = @DERANGEDEXPLORER AND `source_type`=0; 
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, 
`event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, 
`action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES 
(@DERANGEDEXPLORER,0,0,1,8,0,100,1,@GRICKSBONESAW,0,0,0,80,@NPC_REWARD*100+1,2,0,0,0,0,16,0,0,0,0,0,0,0, 'Deranged Explorer- Script - Give Quest Credit'),
(@DERANGEDEXPLORER,0,1,0,61,0,100,1,0,0,0,0,41,1000,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Deranged Explorer - Despawn after 1 second');
@Aokromes

This comment has been minimized.

Copy link
Member

commented Jun 23, 2014

This is valid?

@dr-j

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2014

The below is all what is needed and works as intended

  1. Original tried to run non existent timed action list '@NPC_REWARD*100+1' which did not exist but this quest does need sai to give credit as that weeks, sai is only needed to despawn to prevent item been used multiple times on same npc
  2. If there was a script would have been bad target as target 16 which is invalid for a action to execute script
SET @GRICKSBONESAW     :=43286;
SET @DERANGEDEXPLORER  :=23967;

DELETE FROM `conditions` WHERE `SourceEntry`=@GRICKSBONESAW AND `SourceTypeOrReferenceId`=17;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES
(17,0,@GRICKSBONESAW ,0,0,36,1,0,0,0,1,0,'', 'Gricks Bonesaw can target only a corpse'),
(17,0,@GRICKSBONESAW ,0,0,31,1,3,@DERANGEDEXPLORER,0,0,0,'', 'Gricks Bonesaw can target only Deranged Explorer');
UPDATE `creature_template` SET `AIName`='SmartAI' WHERE `entry` = @DERANGEDEXPLORER; 
DELETE FROM `smart_scripts` WHERE `entryorguid` = @DERANGEDEXPLORER AND `source_type`=0; 
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, 
`event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, 
`action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES 
(@DERANGEDEXPLORER,0,0,1,8,0,100,1,@GRICKSBONESAW,0,0,0,41,1000,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Deranged Explorer - On Spellhit Despawn after 1 second');

@Aokromes Aokromes closed this in 6bd0ef7 Jun 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.