[Item/Trade] Enchanting does not work from trade window

[click]

CORE revision: Trinity Core 10937+
Database: TDB 335.11.36
Patches: AntiCheat1

1. Open a trade window between two players
2. Player 1 puts a weapon/armor in "Will Not Be Traded" window
3. Player 2 enchants said item
4. Trade will always display error message "Item Not Ready"

Normal item/gold trading works fine. I don't know if other "will not be traded" besides enchanting is bugged, but I'd assume so.

[click]

Author: simlt
Just pasting my comment from googlecode issue tracker:

The problem is CheckCast() in WorldSession::HandleAcceptTradeOpcode that is cheching items with m_castItemGUID unitialized, resulting in an error.
Fix:
diff --git a/src/server/game/Server/Protocol/Handlers/TradeHandler.cpp b/src/server/game/Server/Protocol/Handlers/TradeHandler.cpp
--- a/src/server/game/Server/Protocol/Handlers/TradeHandler.cpp
+++ b/src/server/game/Server/Protocol/Handlers/TradeHandler.cpp
@@ -353,6 +353,7 @@

         my_spell = new Spell(_player, spellEntry, true);
         my_spell->m_CastItem = castItem;

•        my_spell->m_castItemGUID = castItem ? castItem->GetGUID() : 0;
       my_targets.setTradeItemTarget(_player);
       my_spell->m_targets = my_targets;
  

@@ -388,6 +389,7 @@

         his_spell = new Spell(trader, spellEntry, true);
         his_spell->m_CastItem = castItem;

•        his_spell->m_castItemGUID = castItem ? castItem->GetGUID() : 0;
       his_targets.setTradeItemTarget(trader);
       his_spell->m_targets = his_targets;
  

[click]

Author: xianx
This patch will crash the server when a player attempts to enchants someone's wrist item.

[click]

Author: micckkk

{{{
This patch will crash the server when a player attempts to enchants someone's wrist item.
}}}

it's Really?

[overy]

Hmm now no work tested on rev: f4f16ae